TableSasBuilder pattern changes #11790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christothes
added
Client
christothes
changed the title
tg-msft
reviewed
May 6, 2020
sdk/tables/Azure.Data.Tables/api/Azure.Data.Tables.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
Comment on lines
236
to
237
| [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)] | ||
| public string Version { get { throw null; } set { } } |
There was a problem hiding this comment.
We should probably just delete the Version property. The Storage folks decided they'd only support latest and we might as well follow suit unless we explicitly decide otherwise.
There was a problem hiding this comment.
I think I'll make it internal so that we can still set it from the latest version defined in TableClientOptions
JeffreyRichter
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to improve the discoverability and usability of generating Shared Access Signature tokens for the Table service. The primary change is the introduction of a new
GetSasBuildermethod on theTableClientand some improved defaults to theTableSasBuilderctor to help guide developers to success.